From 090e7cbafdd67fe933ee8674b76d91103d8f858e Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Mon, 7 May 2012 13:32:28 +0100 Subject: [PATCH] kexec: clear notes during setup Explicity zero the memory backing the crash notes during setup. This allows the crash environment to be rather more certain whether the crash notes were actually written, rather than trusting that the memory was clear beforehand. Signed-off-by: Andrew Cooper Committed-by: Keir Fraser --- xen/common/kexec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/common/kexec.c b/xen/common/kexec.c index 444cae1b03..09a56249e2 100644 --- a/xen/common/kexec.c +++ b/xen/common/kexec.c @@ -401,7 +401,7 @@ static int kexec_init_cpu_notes(const unsigned long cpu) /* If we dont care about the position of allocation, malloc. */ if ( low_crashinfo_mode == LOW_CRASHINFO_NONE ) - note = xmalloc_bytes(nr_bytes); + note = xzalloc_bytes(nr_bytes); /* Protect the write into crash_notes[] with a spinlock, as this function * is on a hotplug path and a hypercall path. */ @@ -520,6 +520,8 @@ static int __init kexec_init(void) if ( ! crash_heap_current ) return -ENOMEM; + memset(crash_heap_current, 0, crash_heap_size); + crash_heap_end = crash_heap_current + crash_heap_size; } -- 2.30.2